Slitaz Next package receipt v2 issue

mistfire · 2020-04-26 11:31:08

I think putting DEPENDS variable on genpkg_rules() function on slitaz next receipt is a bad idea (Example below). Its harder to determine its package dependency if there is no internet connection.

# SliTaz package receipt v2.

# FIXME : Check if the tarball comes with a .desktop and a pixmap files

# Then remove the section in genpkg_rules() that creates them

PACKAGE="pingus"

VERSION="0.7.6"

CATEGORY="games"

SHORT_DESC="Free Lemmings-like game"

MAINTAINER="maintainer@slitaz.org"

LICENSE="GPL2"

WEB_SITE="https://pingus.seul.org/"

TARBALL="$PACKAGE-$VERSION.tar.bz2"

WGET_URL="http://pingus.seul.org/files/$TARBALL"

BUILD_DEPENDS="boost-dev boost-signals libpng-dev scons2 sdl-dev \

sdl-image-dev sdl-mixer-dev"

compile_rules()

{

sed -i 's/png_ptr->jmpbuf/png_jmpbuf(png_ptr)/' \

src/screenshot.cpp

scons || return 1

install -Dm755 pingus $install/usr/bin/pingus

mkdir -p $install/usr/share/pingus

cp -r data $install/usr/share/pingus

# the tarball doesn't contain any .desktop file, nor a pixmap

# let's create them

install -Dm644 $src/data/images/core/editor/actions.png \

$install/usr/share/pixmaps/pingus.png

install -Dm644 $stuff/pingus.desktop \

$install/usr/share/applications/pingus.desktop

}

genpkg_rules()

{

copy @std

DEPENDS="boost-signals gcc-lib-base sdl sdl-image sdl-mixer"

}

It is better to place it on global declaration like the slitaz rolling receipt does (Example below)